Conf: allow unversioned challenge names. #58
Merged
+29
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensh63
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the "challenge" directive parsing by allowing unversioned challenge names alongside the existing versioned ones. This change is inspired by Certbot's --preferred-challenges approach and makes the configuration more user-friendly.
- Allow both versioned (
http-01,tls-alpn-01) and unversioned (http,tls-alpn) challenge names - Replace the generic
From<&str>implementation with explicit pattern matching for better validation - Update documentation to reflect the new unversioned options
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/conf.rs | Replaces generic string conversion with explicit pattern matching for challenge validation |
| src/acme/types.rs | Removes the From<&str> implementation for ChallengeKind |
| t/acme_conf_issuer.t | Adds test for unversioned challenge name and error handling |
| README.md | Documents the new unversioned challenge name options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Simplify "challenge" directive parsing.
bavshin-f5
force-pushed
the
challenge-names
branch
from
1777183 to
b555c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify "challenge" directive parsing.
Inspired by Certbot's
--preferred-challenges.